Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that schema files are correctly published #2868

Conversation

tigrannajaryan
Copy link
Member

This downloads the schema files from https://opentelemetry.io/schemas/ and
verifies their content.

Next time we make a release this will force us to make sure
https://github.com/open-telemetry/opentelemetry.io repo is updated
before we make the release.

This helps prevent issues like open-telemetry/opentelemetry.io#1846

This downloads the schema files from https://opentelemetry.io/schemas/ and
verifies their content.

Next time we make a release this will force us to make sure
https://github.com/open-telemetry/opentelemetry.io repo is updated
before we make the release.

This helps prevent issues like open-telemetry/opentelemetry.io#1846
@tigrannajaryan
Copy link
Member Author

This is expected to fail now since 1.13 and 1.14 schema files are not published.

@tigrannajaryan tigrannajaryan marked this pull request as ready for review October 11, 2022 18:50
@tigrannajaryan tigrannajaryan requested review from a team October 11, 2022 18:50
@tigrannajaryan
Copy link
Member Author

@tigrannajaryan
Copy link
Member Author

Please review. This should be re-run and merged after open-telemetry/opentelemetry.io#1846 is fixed.

@tigrannajaryan
Copy link
Member Author

open-telemetry/opentelemetry.io#1846 is fixed, re-running the checks, they should pass this time.

@tigrannajaryan
Copy link
Member Author

@carlosalberto
Copy link
Contributor

LGTM but we should also document how it is expected to update opentelemetry.io (simple PR with the new file?).

@tigrannajaryan
Copy link
Member Author

LGTM but we should also document how it is expected to update opentelemetry.io (simple PR with the new file?).

It is updated by bumping the commit hash of the submodule content-modules/opentelemetry-specification in https://github.com/open-telemetry/opentelemetry.io repo.

I will add it to the docs.

@tigrannajaryan
Copy link
Member Author

I documented the release procedure, PTAL.

@tigrannajaryan
Copy link
Member Author

tigrannajaryan commented Oct 12, 2022

@tigrannajaryan
Copy link
Member Author

@carlosalberto please take a look at the release procedure.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan merged commit ccf0fcc into open-telemetry:main Oct 17, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/check-schema-published branch October 17, 2022 21:06
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content.

Next time we make a release this will force us to make sure
https://github.com/open-telemetry/opentelemetry.io repo is updated
before we make the release.

This helps prevent issues like open-telemetry/opentelemetry.io#1846

Also add release procedure to the docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants