-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that schema files are correctly published #2868
Verify that schema files are correctly published #2868
Conversation
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846
This is expected to fail now since 1.13 and 1.14 schema files are not published. |
Please review. This should be re-run and merged after open-telemetry/opentelemetry.io#1846 is fixed. |
open-telemetry/opentelemetry.io#1846 is fixed, re-running the checks, they should pass this time. |
LGTM but we should also document how it is expected to update opentelemetry.io (simple PR with the new file?). |
It is updated by bumping the commit hash of the submodule I will add it to the docs. |
I documented the release procedure, PTAL. |
|
@carlosalberto please take a look at the release procedure. |
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846 Also add release procedure to the docs.
This downloads the schema files from https://opentelemetry.io/schemas/ and
verifies their content.
Next time we make a release this will force us to make sure
https://github.com/open-telemetry/opentelemetry.io repo is updated
before we make the release.
This helps prevent issues like open-telemetry/opentelemetry.io#1846