Contributing Geo fields from ECS #2835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
scheler
reviewed
Sep 26, 2022
| | `NA` | North America | | ||
| | `OC` | Oceania | | ||
| | `SA` | South America | | ||
| <!-- endsemconv --> |
There was a problem hiding this comment.
- For mobile devices, the geo attributes will be changing as the user moves around and they cannot be updated on the
Resourcecurrently. This PR will have to wait until Ephemeral Resource Attributes oteps#208 is resolved or there's another mechanism introduced that allows changing attributes on a Resource. - For apps running in data centers, I believe the customers will have to run a Geo mapping service to map the IP to the geo coordinates. If for some reason this service is unavailable, there should be a way to pass the original source IP in the
Resourceso that the telemetry backends can use that for the geo mapping. Can you include support for that in this PR or add a reference to it if it's already there?
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/semantic-conventions#1033
Changes
Adds
geonamespace from the Elastic Common Schema to the resource attributes to allow filtering and grouping of observability data by geo location.Related OTEP: open-telemetry/oteps#199