add user agent to OTLP exporter spec #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/user-agent
branch
from
707b95f
to
84bcb39
Compare
mwear
reviewed
Jul 21, 2022
reyang
reviewed
Jul 26, 2022
reyang
reviewed
Jul 26, 2022
arminru
added
area:sdk
carlosalberto
approved these changes
Aug 8, 2022
|
Overall good, but we need more eyes on this. @open-telemetry/specs-approvers please take a look. |
The following PR adds a section to the OTLP exporter about setting a user agent. This was implemented in the otel collector and provides users with additional information to troubleshoot their telemetry pipelines with.
codeboten
force-pushed
the
codeboten/user-agent
branch
from
f5a5afa
to
e950aef
Compare
|
I would make this an "option" maybe opt-out. |
MSNev
approved these changes
Aug 9, 2022
@bogdandrutu today most (i believe at least all grpc and many http) OTLP exporters already have a user agent header, something like |
jmacd
approved these changes
Aug 9, 2022
reyang
approved these changes
Aug 12, 2022
arminru
approved these changes
Aug 12, 2022
jmacd
approved these changes
Aug 17, 2022
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
|
@bogdandrutu Any further opinion on this? |
tigrannajaryan
approved these changes
Aug 18, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jsuereth
approved these changes
Sep 20, 2022
arminru
approved these changes
Sep 20, 2022
3 tasks
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The following PR adds a section to the OTLP exporter about setting a user agent. This was implemented in the otel collector and provides users with additional information to troubleshoot their telemetry pipelines with. This was discussed in the context of #2501. It's worth noting that the OpenTelemetry collector is currently setting a user agent in the format:
Additionally, existing exporters are already sending this header (using whatever the underlying library is setting), it's just not set to anything OpenTelemetry specific.
Related issues #2501