Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Instrumentation Scope Attributes #2579

Merged
merged 9 commits into from
Jun 11, 2022
Merged

Introduce Instrumentation Scope Attributes #2579

merged 9 commits into from
Jun 11, 2022

Conversation

tigrannajaryan
Copy link
Member

Implements OTEP 201: https://github.com/open-telemetry/oteps/blob/main/text/0201-scope-attributes.md

Another PR will opened against the https://github.com/open-telemetry/opentelemetry-proto
repository to add the necessary fields to the messages.

@tigrannajaryan tigrannajaryan requested review from a team May 24, 2022 14:34
@tigrannajaryan
Copy link
Member Author 

FILE: ./CONTRIBUTING.md
  [✖] http://slack.cncf.io/

  28 links checked.

  ERROR: 1 dead links found!
  [✖] http://slack.cncf.io/ → Status: 404
make: *** [Makefile:31: markdown-link-check] Error 1

A similar problem was reported by someone else: open-telemetry/community#1061
We should probably replace by https://cloud-native.slack.com/ which seems to work correctly.

Oberon00
Oberon00 reviewed May 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
@Oberon00 Oberon00 added area:api Cross language API specification issue spec:metrics Related to the specification/metrics directory spec:logs Related to the specification/logs directory spec:trace Related to the specification/trace directory labels May 24, 2022
@tigrannajaryan tigrannajaryan changed the title Introduce Scope Attributes Introduce Instrumentation Scope Attributes May 24, 2022
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this pull request May 24, 2022
@tigrannajaryan
Introduce Scope Attributes
a504392 
Implements OTEP 201: https://github.com/open-telemetry/oteps/blob/main/text/0201-scope-attributes.md

Corresponding specification PR: open-telemetry/opentelemetry-specification#2579
@tigrannajaryan tigrannajaryan mentioned this pull request May 24, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this pull request May 24, 2022
@tigrannajaryan
Introduce Scope Attributes
1480c4e 
Implements OTEP 201: https://github.com/open-telemetry/oteps/blob/main/text/0201-scope-attributes.md

Corresponding specification PR: open-telemetry/opentelemetry-specification#2579
@tigrannajaryan
Copy link
Member Author

Corresponding proto PR: open-telemetry/opentelemetry-proto#395

@tigrannajaryan
Copy link
Member Author

@jsuereth @yurishkuro @jmacd @djaglowski @MrAlias this brings the OTEP201 to the spec. Please review/approve.

@tigrannajaryan
Copy link
Member Author

Let's merge this after 1.12 release.

@reyang reyang merged commit 8ed127a into open-telemetry:main Jun 11, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/scope-attr branch June 12, 2022 00:10
tigrannajaryan added a commit to open-telemetry/opentelemetry-proto that referenced this pull request Jun 12, 2022
@tigrannajaryan
Introduce Scope Attributes (#395)
96bc1ec 
Implements OTEP 201: https://github.com/open-telemetry/oteps/blob/main/text/0201-scope-attributes.md

Corresponding specification PR: open-telemetry/opentelemetry-specification#2579
@jtescher jtescher mentioned this pull request Jun 16, 2022
Closed
@tigrannajaryan tigrannajaryan mentioned this pull request Jun 21, 2022
Closed
@tidal tidal mentioned this pull request Jun 27, 2022
Closed
@pirgeo pirgeo mentioned this pull request Jun 29, 2022
Merged
@joaopgrassi joaopgrassi mentioned this pull request Jul 21, 2022
Open
@lalitb lalitb mentioned this pull request Jul 21, 2022
Merged
3 tasks
@jmacd jmacd mentioned this pull request Aug 17, 2022
Closed
@jack-berg jack-berg mentioned this pull request Aug 17, 2022
Open
7 tasks
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
@tigrannajaryan @beeme1mr
Introduce Instrumentation Scope Attributes (open-telemetry#2579)
f3502f9
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
@tigrannajaryan @beeme1mr
Introduce Instrumentation Scope Attributes (open-telemetry#2579)
3c676ea
@Oberon00 Oberon00 mentioned this pull request Sep 1, 2022
Closed
This was referenced Oct 7, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oberon00 Oberon00 Oberon00 approved these changes

@lalitb lalitb lalitb left review comments

@carlosalberto carlosalberto carlosalberto approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@jmacd jmacd jmacd approved these changes

@MrAlias MrAlias MrAlias approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@jmacd jmacd

Labels
area:api Cross language API specification issue spec:logs Related to the specification/logs directory spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tigrannajaryan @carlosalberto @Oberon00 @lalitb @yurishkuro @jmacd @MrAlias @joaopgrassi @reyang @jack-berg