Pin markdownlint-cli version and apply fixes #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
the
editorial
This was referenced Feb 7, 2022
yurishkuro
approved these changes
Feb 7, 2022
MrAlias
approved these changes
Feb 7, 2022
bogdandrutu
approved these changes
Feb 7, 2022
|
Thanks for the fix. |
chalin
reviewed
Feb 15, 2022
| - If schema_url field is non-empty both in Resource* message and in the | ||
| contained InstrumentationLibrary* message then the value in | ||
| InstrumentationLibrary* message takes the precedence. | ||
| - If schema_url field is non-empty both in Resource\*message and in the |
There was a problem hiding this comment.
This erased the space between Resource* and message. I don't believe that was intended, right?
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Pin markdownlint-cli version * Apply markdownlint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some breaking changes in the most recent markdownlint-cli version (see https://github.com/igorshubovych/markdownlint-cli/releases) cause all current checks to fail. This PR pins its version so this does not happen again and applies the fixes proposed by markdownlint (inconsistent emphases within one file and unescaped asterisks).