-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic conventions for jvm cpu metrics #2292
Conversation
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
# Conflicts: # specification/metrics/semantic_conventions/runtime-environment-metrics.md
Here's a summary of the proposed metrics and their corresponding sources. Hopefully this makes it a bit easier to evaluate the value of these. This summarizes the information from @jonatan-ivanov's gist.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
We discussed in the 2/24/2022 Java SIG meeting. Can java folks take a look at this and comment? /cc @kittylyst @trask My thoughts:
|
I'm thinking now that it may be good to reuse I have sent #2388 to clarify that these should be interpreted as container-level and not host-level metrics when emitted from inside a container. Should we scale back this PR for now to just these two?
I noticed there's already a
so I don't think we should reuse in this case and need one under |
I think we have more clarity now from discussions in #2384 and #2388. I think there's still one open question #2392 (comment) and then I think we'll have clarity on how to proceed. @jonatan-ivanov thanks for your patience |
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
/unstale |
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
# Conflicts: # specification/metrics/semantic_conventions/runtime-environment-metrics.md
@open-telemetry/technical-committee is this not the right place to define JVM metrics that we want to emit? would it be better if we just document these in the Java repo and create our own "jvm metrics" schema url? thx |
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Show resolved
Hide resolved
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
The reason to block was resolved, still a very confusion proposal for system under process
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
I've removed the |
@jonatan-ivanov would you resolve the merge conflicts and clear the CI? Thanks! |
specification/metrics/semantic_conventions/runtime-environment-metrics.md
Outdated
Show resolved
Hide resolved
# Conflicts: # specification/metrics/semantic_conventions/runtime-environment-metrics.md
@reyang Would you approve the workflow to run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jonatan-ivanov please send a follow up PR to update the changelog (which is an editorial/trivial change). |
Initial draft for JVM runtime cpu semantic conventions.
I created a gist where you can see where these values are coming from: https://gist.github.com/jonatan-ivanov/0449619cb6f851ce67d70e47a6a1fb73
/cc @trask @jack-berg