Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docfx sanity check #2285

Merged
merged 14 commits into from
Mar 24, 2022
Merged

Update docfx sanity check #2285

merged 14 commits into from
Mar 24, 2022

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Jan 22, 2022

Changes

Update docfx sanity check to use the latest version, which runs natively on linux and and is capable of more validations.

Fixes a broken anchor and a broken HTML tag problem detected by the new tool.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 22, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@yufeih
Copy link
Contributor Author

yufeih commented Jan 24, 2022

There is one error detected I'm not sure how to update. This file contains a link to README.md which isn't part of the website, I guess it is a trick to link to the parent directory, but there isn't any API specifications page. The API specifications link seems to point to the wrong location on this page

@yufeih yufeih marked this pull request as ready for review January 24, 2022 01:56
@yufeih yufeih requested review from a team January 24, 2022 01:56
@arminru arminru added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Jan 25, 2022
@yufeih @arminru
Update .github/workflows/checks.yaml
af1effc 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 4, 2022
@yufeih
Copy link
Contributor Author

yufeih commented Feb 7, 2022

I've updated the check and it should pass. The checks needs a maintainer approval.

@github-actions github-actions bot removed the Stale label Feb 8, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 15, 2022
@yufeih
Copy link
Contributor Author

yufeih commented Feb 15, 2022

The markdown-lint failure seems not related to this PR.

@github-actions github-actions bot removed the Stale label Feb 16, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 2, 2022
@arminru
Copy link
Member

arminru commented Mar 2, 2022

Hi @yufeih! The markdownlint issue should have been resolved in the meantime, let's give it another try.

@arminru arminru reopened this Mar 2, 2022
@github-actions github-actions bot removed the Stale label Mar 3, 2022
arminru
arminru approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yufeih!

.github/workflows/checks.yaml Show resolved Hide resolved
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 11, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 18, 2022
@arminru arminru reopened this Mar 22, 2022
@arminru arminru mentioned this pull request Mar 24, 2022
Open
@arminru arminru merged commit c36e8a0 into open-telemetry:main Mar 24, 2022
@lmolkova lmolkova mentioned this pull request May 6, 2024
Merged
2 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@yufeih @arminru
Update docfx sanity check (open-telemetry#2285)
9a52636 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru arminru approved these changes

@reyang reyang reyang approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufeih @arminru @reyang @tigrannajaryan