Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database connection pool metrics semantic conventions #2273

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Fixes #2263

Changes

Adds database connection pool metrics semantic conventions.

This PR is based on the DB connection pool metrics implemented in the Splunk Java instrumentation distro:

@mateuszrzeszutek mateuszrzeszutek requested review from a team January 19, 2022 14:16
@arminru arminru added area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory labels Jan 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 9, 2022
@mateuszrzeszutek
Copy link
Member Author

@open-telemetry/specs-approvers @open-telemetry/technical-committee can you take a look at this PR? Thanks!

@github-actions github-actions bot removed the Stale label Feb 10, 2022
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 17, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Feb 26, 2022
@arminru arminru reopened this Mar 2, 2022
@arminru arminru requested a review from a team March 2, 2022 13:32
@mateuszrzeszutek mateuszrzeszutek force-pushed the database-connection-pool-spec branch from 3a5646a to 19a46f8 Compare March 11, 2022 17:15
@arminru
Copy link
Member

arminru commented Mar 11, 2022

@open-telemetry/specs-metrics-approvers please take a look :-)

@github-actions github-actions bot removed the Stale label Mar 12, 2022
@mateuszrzeszutek mateuszrzeszutek force-pushed the database-connection-pool-spec branch from 19a46f8 to 5ef2a08 Compare March 16, 2022 09:43
@mateuszrzeszutek
Copy link
Member Author

@open-telemetry/technical-committee can this PR be merged?

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a corresponding yaml file?

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 25, 2022
@mateuszrzeszutek mateuszrzeszutek force-pushed the database-connection-pool-spec branch from 5ef2a08 to 64e84a9 Compare March 28, 2022 11:51
@mateuszrzeszutek
Copy link
Member Author

Shouldn't there be a corresponding yaml file?

I think we don't have any yaml files for metrics specs yet.

@github-actions github-actions bot removed the Stale label Mar 29, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 7, 2022
@trask
Copy link
Member

trask commented Apr 7, 2022

/unstale

@github-actions github-actions bot removed the Stale label Apr 8, 2022
@mateuszrzeszutek mateuszrzeszutek force-pushed the database-connection-pool-spec branch from b19c00b to 90842b6 Compare April 14, 2022 14:17
@reyang reyang merged commit d25321e into open-telemetry:main Apr 19, 2022
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database connection pool semantic conventions
8 participants