-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics supplemental guidelines for async views #2208
Metrics supplemental guidelines for async views #2208
Conversation
This looks great to me. I think it nails options available to SDKs and provides a simple, allowable implementation, demonstrating why it works. Should we recommend ONE option to SDKs first though, while allowing the others? |
Co-authored-by: legendecas <legendecas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification! I wonder: for the Synchronous example, there are the Delta, then the Cumulative aggregation temporality sections, but for Asynchronous there is the Cumulative section first, then the Delta section. In the attribute removal section right after that, there are references to Cumulative temporality again. Do you think it would make sense to swap the Delta and Cumulative sections for the Asynchronous example?
…ication into jmacd/supplemental_async_view
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
…telemetry-specification into jmacd/supplemental_async_view
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@jmacd Should we reopen this PR? It had a few approvals already, etc ;) |
Given that these are guidelines--not specs--and have several approvals, I feel this can merge. @reyang PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixes #2187
Changes
Clarifies the available strategies for calculating asynchronous Views and what it means for the receiver, especially when streams "die" and restart, requiring reset detection.
Related issues #1874