Update log data model JSON examples to use nanosecond values #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumoroku
approved these changes
Oct 13, 2021
jmacd
approved these changes
Oct 13, 2021
anuraaga
approved these changes
Oct 14, 2021
jsuereth
approved these changes
Oct 14, 2021
codeboten
approved these changes
Oct 14, 2021
|
Can't update the branch (EasyCLA unhappy?). Will re-create the PR. |
|
Please re-approve here: #2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data model says that timestamps are nanosecond values, but examples use milliseconds.
Updated to use stringified nanoseconds according to #1637
Fixes: #1049