Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set Span.Status for 4xx http status codes for SERVER spans #1998

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Don't set Span.Status for 4xx http status codes for SERVER spans #1998

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93c48e1
Don't set Span.Status for 4xx http status codes for SERVER spans
iNikem Oct 5, 2021
8a1a831
Update specification/trace/semantic_conventions/http.md
iNikem Oct 6, 2021
936a1da
Update CHANGELOG.md
iNikem Oct 7, 2021
6f4f746
Merge remote-tracking branch 'upstream/main' into http-status
iNikem Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions specification/trace/semantic_conventions/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ default span name.
the response body; or 3xx codes with max redirects exceeded), in which case status
MUST be set to `Error`.

For HTTP status codes in the 4xx and 5xx ranges, as well as any other code the client
failed to interpret, status MUST be set to `Error`.
For HTTP status codes in the 4xx range span status MUST be left unset in case of `SpanKind.SERVER`
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
and MUST be set to `Error` otherwise.
iNikem marked this conversation as resolved.
Show resolved Hide resolved

For HTTP status codes in the 5xx range, as well as any other code the client
failed to interpret, span status MUST be set to `Error`.

Don't set the span status description if the reason can be inferred from `http.status_code`.

Expand Down