Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove tracestate #198

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions milestones.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ Example of scope for extended SDK:
3. Discussions like
1. Native (POJO) object vs. Proto-generated object with proto dependency in
SDK
4. Tracestate manipulation callbacks
5. Other
4. Other

First iteration of SDK feedback – **mid August** we have specs, **End of
August** – first iteration of Java SDK complete.
Expand Down
13 changes: 2 additions & 11 deletions specification/api-tracing.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,8 @@ propagated along side of a distributed context. `SpanContext`s are immutable.
The OpenTelemetry `SpanContext` representation conforms to the [w3c TraceContext
specification](https://www.w3.org/TR/trace-context/). It contains two
identifiers - a `TraceId` and a `SpanId` - along with a set of common
`TraceOptions` and system-specific `TraceState` values. `SpanContext` is
represented as an interface, in order to be serializable into a wider variety of
trace context wire formats.
`TraceOptions`. `SpanContext` is represented as an interface, in order to be
serializable into a wider variety of trace context wire formats.

`TraceId` A valid trace identifier is a 16-byte array with at least one
non-zero byte.
Expand All @@ -181,17 +180,9 @@ byte.
TraceOptions are present in all traces. Currently, the only TraceOption is a
boolean `recorded`
[flag](https://www.w3.org/TR/trace-context/#recorded-flag-00000001).

`Tracestate` carries system-specific configuration data, represented as a list
of key-value pairs. TraceState allows multiple tracing systems to participate in
the same trace.

`IsValid` is a boolean flag which returns true if the SpanContext has a non-zero
TraceID and a non-zero SpanID.

Please review the W3C specification for details on the [Tracestate
field](https://www.w3.org/TR/trace-context/#tracestate-field).

## Span

A `Span` represents a single operation within a trace. Spans can be nested to
Expand Down
4 changes: 0 additions & 4 deletions specification/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ propagated from parent to child **Spans**.
byte (bitmap).
- Sampling bit - Bit to represent whether trace is sampled or not (mask
`0x1`).
- **Tracestate** carries tracing-system specific context in a list of key value
pairs. **Tracestate** allows different vendors propagate additional
information and inter-operate with their legacy Id formats. For more details
see [this](https://w3c.github.io/trace-context/#tracestate-field).

### Links between spans

Expand Down
3 changes: 0 additions & 3 deletions work_in_progress/specification/trace/LogCorrelation.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ The sampling bit of the current span, as a boolean. See

TODO(sebright): Include "samplingScore" once that field is added to the SpanContext.

TODO(sebright): Add a section on fields from the Tracestate. Users should be able to add
vendor-specific fields from the Tracestate to logs, using a callback mechanism.

TODO(sebright): Consider adding parent span ID, to allow recreating the trace structure from logs.

## String format for tracing data
Expand Down