Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific attributes for Apache RocketMQ #1904

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add specific attributes for Apache RocketMQ #1904

merged 1 commit into from
Oct 13, 2021
+102 −3

Conversation

aaron-ai
Copy link
Member

@aaron-ai aaron-ai commented Sep 2, 2021

Changes

Add specific attributes for Apache RocketMQ

Related issues #

Related oteps #1900

@aaron-ai aaron-ai requested review from a team September 2, 2021 12:43
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 2, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels Sep 2, 2021
arminru
arminru reviewed Sep 2, 2021
View reviewed changes
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/messaging.yaml Outdated Show resolved Hide resolved
specification/trace/semantic_conventions/messaging.md Show resolved Hide resolved
specification/trace/semantic_conventions/messaging.md Outdated Show resolved Hide resolved
@aaron-ai
Copy link
Member Author

aaron-ai commented Sep 2, 2021

All issues mentioned above have been fixed.

@aaron-ai aaron-ai force-pushed the pr branch 3 times, most recently from 46eac99 to 2b2cf6e Compare September 2, 2021 15:55
@aaron-ai aaron-ai requested review from Oberon00 and arminru September 2, 2021 16:15
@aaron-ai
Copy link
Member Author

any more feedback? @arminru @Oberon00

@arminru arminru requested review from a team September 10, 2021 14:40
@arminru arminru linked an issue Sep 13, 2021 that may be closed by this pull request
Add specific attributes for Apache RocketMQ #1900
Closed
@aaron-ai aaron-ai requested review from mateuszrzeszutek and arminru and removed request for a team September 14, 2021 07:13
@aaron-ai
Copy link
Member Author

All issues above have been addressed. @Oberon00 @mateuszrzeszutek @arminru

@RongtongJin
Copy link

LGTM @aaron-ai @arminru

@aaron-ai
Copy link
Member Author

@open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers @open-telemetry/technical-committee all comments are addressed, could another check and approve it?

@arminru arminru requested review from a team September 16, 2021 09:16
@arminru
Copy link
Member

arminru commented Sep 20, 2021

@open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers PTAL 🙂

@aaron-ai
Copy link
Member Author

@arminru @Oberon00 all conflicts are resolved

@arminru
Copy link
Member

arminru commented Sep 28, 2021

@open-telemetry/specs-approvers @open-telemetry/specs-trace-approvers PTAL 🙂

@tigrannajaryan
Copy link
Member

@arminru I think this is one the PR's that would benefit from the guide that we thought would be helpful to write (the "How to make progress on proposals that do not initially generate enough interest/comments" here).

I don't know anything about Apache RocketMQ, so I cannot contribute very meaningfully to this PR. We need to come up with a good way to make contributions like this easy to make (I don't know yet how).

@tedsuo who are the current members/approvers/maintainers of Instrumentation SIG? I don't see a github team for Instrumentation to mention it. If you know the them can you please invite relevant people to this PR and also it would be great to have a Github team for the future.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 6, 2021
@tigrannajaryan tigrannajaryan mentioned this pull request Oct 7, 2021
Open
@aaron-ai
Copy link
Member Author

aaron-ai commented Oct 8, 2021

This pull request is suspend because of the vocation.

@github-actions github-actions bot removed the Stale label Oct 8, 2021
Oberon00
Oberon00 reviewed Oct 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@aaron-ai aaron-ai requested review from Oberon00 and removed request for a team October 9, 2021 08:16
@Oberon00
Copy link
Member

I un-resolved #1904 (comment), please see my comment there.

@aaron-ai
Copy link
Member Author

could you re-ran the CI? @Oberon00 thanks.

@Oberon00 Oberon00 mentioned this pull request Oct 13, 2021
Closed
@arminru arminru enabled auto-merge (squash) October 13, 2021 08:57
@arminru arminru merged commit a1a8676 into open-telemetry:main Oct 13, 2021
@aaron-ai aaron-ai mentioned this pull request Oct 27, 2022
Closed
6 tasks
@jpkrohling jpkrohling mentioned this pull request Feb 26, 2024
Open
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@aaron-ai
Add specific attributes for Apache RocketMQ (open-telemetry#1904)
16d5690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

@arminru arminru arminru approved these changes

@jsuereth jsuereth jsuereth approved these changes

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@Oberon00 Oberon00 Awaiting requested review from Oberon00

Assignees

@yurishkuro yurishkuro

Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add specific attributes for Apache RocketMQ
8 participants
@aaron-ai @RongtongJin @arminru @tigrannajaryan @Oberon00 @jsuereth @mateuszrzeszutek @yurishkuro