Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semantic conventions] add alibaba cloud as a cloud provider #1831

Merged

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jul 27, 2021

Changes

Add Alibaba Cloud as one of the cloud providers. So that SDK implementations with the generated definition can start working on detector support, etc.

Alibaba Cloud has ~10% of the global market share, ranking third in the world and first in Asia-Pacific.

Related issues open-telemetry/opentelemetry-js#2378

@legendecas legendecas requested review from a team July 27, 2021 12:14
@legendecas legendecas force-pushed the semantic-convention/alibaba-cloud branch from e6b1fe8 to 5f0cc9e Compare July 27, 2021 12:18
@Oberon00
Copy link
Member

Oberon00 commented Jul 27, 2021

Thank you for the PR!
I think you probably also want to update the faas.invoked_provider trace semantic convention.

EDIT: See here:

- id: invoked_provider
type:
allow_custom_values: true
members:
- id: AWS
value: 'aws'
brief: 'Amazon Web Services'
- id: Azure
value: 'azure'
brief: 'Microsoft Azure'
- id: GCP
value: 'gcp'
brief: 'Google Cloud Platform'
required: always
brief: >
The cloud provider of the invoked function.
note: >
SHOULD be equal to the `cloud.provider` resource attribute of the
invoked function.

(note that there is an open tooling issue for sharing enum definitions: open-telemetry/build-tools#32, but I doesn't look like it will be resolved in the foreseeable future)

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory labels Jul 27, 2021
@legendecas legendecas requested a review from a team July 28, 2021 02:41
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also add an entry in CHANGELOG.md for your addition.

specification/resource/semantic_conventions/README.md Outdated Show resolved Hide resolved
@legendecas legendecas force-pushed the semantic-convention/alibaba-cloud branch from 853cb80 to 2f9fbad Compare August 3, 2021 03:04
@legendecas
Copy link
Member Author

Just pushed to trigger unresponsive EasyCLA to re-check.

@arminru arminru enabled auto-merge (squash) August 3, 2021 11:20
@arminru arminru merged commit c35c212 into open-telemetry:main Aug 3, 2021
@legendecas legendecas deleted the semantic-convention/alibaba-cloud branch August 3, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants