Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1780

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Update README.md #1780

merged 4 commits into from
Jul 1, 2021

Conversation

andrewsjg
Copy link
Contributor

Should this be trusting and not 'thrusting'? Whatever the case I don't quite understand the meaning here. Maybe some rewording of this note is in order?

Fixes #

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes. If CHANGELOG.md is updated,
also be sure to update spec-compliance-matrix.md if necessary.

Related issues #

Related oteps #

Should this be trusting and not 'thrusting'? Whatever the case I don't quite understand the meaning here
@andrewsjg andrewsjg requested review from a team June 29, 2021 11:24
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 29, 2021

CLA Signed

The committers are authorized under a signed CLA.

@iNikem
Copy link
Contributor

iNikem commented Jun 29, 2021

I believe it should be "thrashing". Also @andrewsjg , please sign CLA using the link above.

@carlosalberto
Copy link
Contributor

cc @open-telemetry/specs-metrics-approvers

specification/metrics/README.md Outdated Show resolved Hide resolved
Comment on lines 15 to 16
Note: this specification is subject to major changes. To avoid trusting
language client maintainers, we don't recommend OpenTelemetry clients to start

This comment was marked as outdated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"avoid wasting" is a logical double negative. Can replace with "To make better use of maintainers' time"

@andrewsjg
Copy link
Contributor Author

I believe it should be "thrashing". Also @andrewsjg , please sign CLA using the link above.

Thrashing makes more sense.

Better wording of the note at the top
@andrewsjg
Copy link
Contributor Author

I believe it should be "thrashing". Also @andrewsjg , please sign CLA using the link above.

Also signed the CLA. Apologies... New to this

@carlosalberto carlosalberto merged commit 09fe632 into open-telemetry:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants