added JSON RPC specific attributes #1606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Rast1234
changed the title
|
Unfortunately i have to wait for our legal team to review CLA |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Rast1234
changed the title
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Not sure if i can reopen it... |
|
Create new PR?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing attributes for JSON RPC protocol.
Changes
Added attributes:
Not sure if
nullvalues are OK for attributes, maybe need to changerpc.jsonrpc.ida bit. Also not sure iferror_messageis OK because it is arbitrary (but short!) text, can impact cardinality.Related issue: #1601