Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editorial] Move the attribute type extension note for better readability #3925

Closed
carlosalberto opened this issue Mar 6, 2024 · 2 comments
Closed

[editorial] Move the attribute type extension note for better readability #3925

carlosalberto opened this issue Mar 6, 2024 · 2 comments
Assignees
@jmacd

Comments

@carlosalberto
Copy link
Contributor

As part of #3858 specification/common/README.md was added to include a NOTE in the Attributes section:

NOTE: extending the set of attribute value types is a breaking change. This was decided after extensive debate, with arguments as follows: ... etc

Consider moving this to the end of the Standard Attributes sub-section instead, hopefully making things clearer and in the same location.

cc @mattmccleary
@mattmccleary mattmccleary mentioned this issue Mar 6, 2024
Merged
@mattmccleary
Copy link
Contributor

Sure, here's a PR to resolve the issue and resolve feedback from Tigran and I.
#3926

CC: @tigrannajaryan

carlosalberto pushed a commit that referenced this issue Mar 12, 2024
@mattmccleary
Resolves Open Feedback re: Prohibiting Complex Types (#3926)
8e8d157 
## Changes

Resolves open comments from PR (#3858)

1. Clarify the "why" w/o redefining metadata (See
[comment](#3858 (comment)))

2. Keep all the new standard attribute content together in one place

This addresses issue (#3925).
@tigrannajaryan
Copy link
Member

Resolved by #3926

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
@mattmccleary
Resolves Open Feedback re: Prohibiting Complex Types (open-telemetry#…
e4f20b4 
…3926)

## Changes

Resolves open comments from PR (open-telemetry#3858)

1. Clarify the "why" w/o redefining metadata (See
[comment](open-telemetry#3858 (comment)))

2. Keep all the new standard attribute content together in one place

This addresses issue (open-telemetry#3925).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@carlosalberto @jmacd @tigrannajaryan @mattmccleary