Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[file configuration] Clarify environment variable substitution is not recursive. #3894

Closed
marcalff opened this issue Feb 21, 2024 · 1 comment · Fixed by #3913
Closed

[file configuration] Clarify environment variable substitution is not recursive. #3894

marcalff opened this issue Feb 21, 2024 · 1 comment · Fixed by #3913
Assignees
@arminru
Labels
area:configuration Related to configuring the SDK spec:miscellaneous For issues that don't match any other spec label triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@marcalff
Copy link
Member

marcalff commented Feb 21, 2024 •
edited
Loading

The spec for environment variable substitution, in file_configuration, should clarify that substitution is not recursive.

For example:

export PING='${PONG}'
export PONG='${PING}'
some_yaml_node: ${PING}

should evaluate as string ${PONG}, and not call getenv() on PONG.
@marcalff marcalff added the spec:miscellaneous For issues that don't match any other spec label label Feb 21, 2024
@marcalff marcalff mentioned this issue Feb 21, 2024
Open
50 tasks
@reyang reyang added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Feb 28, 2024
@jack-berg
Copy link
Member

I agree. Would you care to open a PR?

marcalff added a commit to marcalff/opentelemetry-specification that referenced this issue Feb 28, 2024
@marcalff
Clarify environment variable substitution is not reccursive
aee5ac1 
Fixes open-telemetry#3894
@marcalff marcalff mentioned this issue Feb 28, 2024
Merged
5 tasks
@marcalff marcalff changed the title [file configuration] Clarify environment variable substitution is not reccursive. [file configuration] Clarify environment variable substitution is not recursive. Feb 29, 2024
@jack-berg jack-berg added the area:configuration Related to configuring the SDK label Mar 25, 2024
carlosalberto pushed a commit that referenced this issue Mar 29, 2024
@marcalff
Clarify environment variable substitution is not recursive (#3913)
1f48f59 
Fixes #3894

## Changes

In the SDK file configuration, clarify environment variable substitution
is not recursive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arminru arminru

Labels
area:configuration Related to configuring the SDK spec:miscellaneous For issues that don't match any other spec label triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify environment variable substitution is not recursive marcalff/opentelemetry-specification
4 participants
@arminru @marcalff @reyang @jack-berg