Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move event.domain from InstrumentScope to LogRecord #2939

Closed
jack-berg opened this issue Nov 11, 2022 · 0 comments · Fixed by #2940
Closed

Move event.domain from InstrumentScope to LogRecord #2939

jack-berg opened this issue Nov 11, 2022 · 0 comments · Fixed by #2940
Assignees
Labels
spec:logs Related to the specification/logs directory

Comments

@jack-berg
Copy link
Member

In the 11/9 Log SIG we discussed whether it was appropriate for event.domain to be defined as an attribute in InstrumentationScope, or is more appropriate an attribute on LogRecord.

We reasoned that LogRecord is more appropriate as follows:

  • Because InstrumentationScope is a build-time concept, its not appropriate to InstrumentationScopes with the same name / version / schema, but different attributes.
  • Therefore, it wouldn't be appropriate to have a single InstrumentationScope emit events in more than one event.domain.
  • This means that emitting events in different domains requires you to emit those events in different InstrumentationScopes.
  • We did not intend event.domain to impact decisions about how broad or narrow a particular InstrumentationScope is. Perhaps the InstrumentationScope represents an entire application. It should be perfectly valid to emit events in different domains.

Conclusion: Move event.domain to an attribute on LogRecord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants