Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settle on linebreak style #192

Closed
c24t opened this issue Jul 23, 2019 · 10 comments
Closed

Settle on linebreak style #192

c24t opened this issue Jul 23, 2019 · 10 comments
Labels
needs discussion Need more information before all suitable labels can be applied

Comments

@c24t
Copy link
Member

c24t commented Jul 23, 2019

Motivated by #190 (comment).

We don't have a consistent style for wrapping long lines of prose. It may not be worth the trouble to enforce a specific style, but we should either pick one now or agree not to enforce this going forward.

Of the files in the spec that have a mostly consistent style:

Hard breaks at 80 chars: 6 files, generally @SergeyKanzhelev and @bogdandrutu
Hard breaks at > 80 chars: 2 files, generally @songy23
Break at end of paragraph: 3 files, generally @tigrannajaryan, @mayurkale22, and @iredelmeier

This is almost entirely a matter of personal taste, so if anyone has an opinion I'd like to hear it. I'd prefer to put a single break at the end of each sentence and blank lines in between paragraphs because this tends to produce nice diffs.

@arminru
Copy link
Member

arminru commented Jul 24, 2019

+1 for your proposal
Nice diffs are nice and it makes the raw MD files easier
to read since the breaks are more natural rather than chopping
off sentences randomly with hard breaks.
In addition to that, hard breaks are annoying to obey when one is editing simple stuff using the web interface or applies review suggestions there.

@bogdandrutu
Copy link
Member

I would personally vote to have a limit because otherwise some lines will have >300 chars (or even more).

@c24t
Copy link
Member Author

c24t commented Jul 24, 2019

Applying review suggestions is a good point: since github doesn't let you suggest multiline hunks this means the OP has to break out the editor for even simple changes.

I'm happy with 300+ char lines since I can soft wrap them in my own editor.

@c24t
Copy link
Member Author

c24t commented Jul 24, 2019

Using soft breaks also means that reviewers don't have to change the browser size to match the text width on the review page to see a nice diff.

Compare hard breaks in #163:

Screen Shot 2019-07-24 at 12 59 09 PM

to soft breaks in #186:

Screen Shot 2019-07-24 at 1 01 02 PM

@tigrannajaryan
Copy link
Member

I suggest that we do one of these:

  1. Hard breaks at 80 chars.
  2. Break at end of paragraph.

Either works fine for diffing in Github. 1 is more manual work, 2 requires your editor to support soft wrapping. My vote goes to 2, but I am open to doing 1 if majority wants that.

I would refrain from hard breaking at large column numbers precisely because of what @c24t said above.

@carlosalberto
Copy link
Contributor

I also vote for having a limit - either 80 or 100 should be fine (and friendlier).

@GreyCat
Copy link

GreyCat commented Jul 25, 2019

If I can chime in, from my perspective, hard limit at 80 or 100 will be the best for reasons like:

  • Embedding docs into code comments (as docstrings, etc) without major reformatting
  • Compatibility with large set of tools (Azure DevOps code viewer, to some extent, GitHub)
  • GitHub only allows line-level precision of comments, so having multiple hard lines makes it easier to pinpoint things to comment on in large paragraph.

@iredelmeier
Copy link
Member

Strong support for soft breaks:

  • Makes editing MUCH easier. (Copy editing, which we very much need to do, basically requires that we reformat with soft breaks as a first step. This is especially true if we get help from a technical writer who's less comfortable with tooling that has explicit support for hard breaks.)
  • Better git history
  • Allows for more personal customization in editors

@iredelmeier iredelmeier added the needs discussion Need more information before all suitable labels can be applied label Jul 30, 2019
@Oberon00
Copy link
Member

Oberon00 commented Aug 6, 2019

I think that soft breaks would be best, as, contrary to source code files, soft-wrapping works very well for (plain english) text files. Regarding the pin-pointing things in lines issue: You could add a hard break after every sentence, or after every clause (wherever you think it makes sense semantically).

@c24t
Copy link
Member Author

c24t commented Aug 13, 2019

From the spec SIG call today: let's use soft breaks, revisit if we decide that this was a mistake.

@c24t c24t closed this as completed Aug 13, 2019
c24t added a commit to SergeyKanzhelev/opentelemetry-specification that referenced this issue Oct 1, 2019
SergeyKanzhelev added a commit that referenced this issue Oct 14, 2019
* error handling proposal

* added self-monitoring

* Reword principles

* Reword guidance

* Reword diagnostics

* Reword exceptions

* Add note on logs, callbacks

* Formatting

* formatting and a mention of ToString

* dynamic languages

* returning noops, not nulls

* Reformat for #192

* Update specification/error-handling.md

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>
SergeyKanzhelev added a commit to SergeyKanzhelev/opentelemetry-specification that referenced this issue Feb 18, 2020
* error handling proposal

* added self-monitoring

* Reword principles

* Reword guidance

* Reword diagnostics

* Reword exceptions

* Add note on logs, callbacks

* Formatting

* formatting and a mention of ToString

* dynamic languages

* returning noops, not nulls

* Reformat for open-telemetry#192

* Update specification/error-handling.md

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Need more information before all suitable labels can be applied
Projects
None yet
Development

No branches or pull requests

8 participants