-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for response headers #1355
Comments
This sounds to me like something we should do after GA. |
is this a duplicate of #3811? |
@dyladan right, thanks for the clarification. I hope this will be standardised soon - it will be useful to return the traceid to clients even when there is no propagation, so the client can attach the traceid to bugs/issues. |
@austinlparker One of those is closed, another is discussing wire format. Neither cover the question raised in this issue - how can instrumentation actually use propagators to inject baggage into response. @arminru why is it "not planned"? How do we plan to support W3C response header? |
@yurishkuro I marked it as a duplicate of the two tickets as stated above, so this one shows up as Closed in gray. If this issue turns out not to duplicate the others, it could be re-opened and discussed further, of course. |
@jpkrohling I think we should keep this one as a tracking. It states a problem that requires a new API (#3825 was a solution, but was closed). #3811 is related but goes into a completely different discussion about the format - a specific implementation detail of one possible implementation of the API. #3811 cannot be implemented without solving this issue, as you said, but the discussion there will completely side-track us. |
What are you trying to achieve?
Similar to OpenTracing and OpenCensus, the context in OpenTelemetry is only propagated forward, from caller to callee. However, some tracing systems instrument both directions, and may even require different IDs to be sent in the response, in order to explicitly capture the causality via events on a DAG. The OTEL API for Propagators currently provides no ability to distinguish whether the context is being serialized for the purpose of shipping it downstream or upstream.
Should there be some facility in the Propagator API to account for that?
Additional context.
Somewhat similar issue will arise when people try to implement the W3C Trace Context Response Header.
The text was updated successfully, but these errors were encountered: