Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for response headers #1355

Open
yurishkuro opened this issue Jan 20, 2021 · 11 comments
Open

API for response headers #1355

yurishkuro opened this issue Jan 20, 2021 · 11 comments
Labels
area:api Cross language API specification issue spec:trace Related to the specification/trace directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor

Comments

@yurishkuro
Copy link
Member

What are you trying to achieve?

Similar to OpenTracing and OpenCensus, the context in OpenTelemetry is only propagated forward, from caller to callee. However, some tracing systems instrument both directions, and may even require different IDs to be sent in the response, in order to explicitly capture the causality via events on a DAG. The OTEL API for Propagators currently provides no ability to distinguish whether the context is being serialized for the purpose of shipping it downstream or upstream.

Should there be some facility in the Propagator API to account for that?

Additional context.

Somewhat similar issue will arise when people try to implement the W3C Trace Context Response Header.

@yurishkuro yurishkuro added the spec:trace Related to the specification/trace directory label Jan 20, 2021
@carlosalberto
Copy link
Contributor

This sounds to me like something we should do after GA.

@andrewhsu andrewhsu added release:after-ga Not required before GA release, and not going to work on before GA area:api Cross language API specification issue labels Jan 22, 2021
@meastp
Copy link

meastp commented Apr 10, 2024

is this a duplicate of #3811?

@dyladan
Copy link
Member

dyladan commented Apr 16, 2024

I think #3811 is more of a duplicate of this, but they're slightly different. This issue asks for the propagators API to include a general mechanism for response headers, and #3811 asks for a specific one.

@meastp
Copy link

meastp commented Apr 16, 2024

@dyladan right, thanks for the clarification. I hope this will be standardised soon - it will be useful to return the traceid to clients even when there is no propagation, so the client can attach the traceid to bugs/issues.

@austinlparker
Copy link
Member

Discussion has mostly moved on to #3811 and #3825; Closing this in favor of those.

@arminru arminru closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
@yurishkuro
Copy link
Member Author

Discussion has mostly moved on to #3811 and #3825; Closing this in favor of those.

@austinlparker One of those is closed, another is discussing wire format. Neither cover the question raised in this issue - how can instrumentation actually use propagators to inject baggage into response.

@arminru why is it "not planned"? How do we plan to support W3C response header?

@arminru
Copy link
Member

arminru commented Jun 26, 2024

@yurishkuro I marked it as a duplicate of the two tickets as stated above, so this one shows up as Closed in gray.
image
Otherwise the default purple "☑️ Completed" would give a first impression that this was already implemented and would be available now.

If this issue turns out not to duplicate the others, it could be re-opened and discussed further, of course.

@yurishkuro yurishkuro reopened this Jun 26, 2024
@yurishkuro
Copy link
Member Author

#3811 is a different issue. #3825 would address this but it's not an issue, it was a PR that is closed.

@svrnm svrnm removed the release:after-ga Not required before GA release, and not going to work on before GA label Jul 8, 2024
@jpkrohling
Copy link
Member

jpkrohling commented Jul 8, 2024

They all have the same purpose. #3811 requires #1355, which is what #3825 attempts to address first.

From my side, it all could be tracked via #3811 for simplicity, but perhaps the TC can triage this.

@svrnm svrnm added the triage:deciding:tc-inbox Needs attention from the TC in order to move forward label Jul 8, 2024
@jack-berg jack-berg added triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor and removed triage:deciding:tc-inbox Needs attention from the TC in order to move forward labels Jul 17, 2024
@jack-berg
Copy link
Member

From my side, it all could be tracked via #3811 for simplicity, but perhaps the TC can triage this.

Discussed in the 7/17/24 TC meeting. We're going to keep this around because although #3811 may solve this, the ask here is more general purpose / not as use-case specific as #3811.

@yurishkuro
Copy link
Member Author

@jpkrohling I think we should keep this one as a tracking. It states a problem that requires a new API (#3825 was a solution, but was closed). #3811 is related but goes into a completely different discussion about the format - a specific implementation detail of one possible implementation of the API. #3811 cannot be implemented without solving this issue, as you said, but the discussion there will completely side-track us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue spec:trace Related to the specification/trace directory triage:accepted:needs-sponsor Ready to be implemented, but does not yet have a specification sponsor
Projects
Status: Spec - Accepted
Development

No branches or pull requests

10 participants