Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update YAML files for semantic conventions once supported by markdown generator #1096

Closed
anuraaga opened this issue Oct 15, 2020 · 2 comments · Fixed by #1550
Closed

Update YAML files for semantic conventions once supported by markdown generator #1096

anuraaga opened this issue Oct 15, 2020 · 2 comments · Fixed by #1550
Assignees
@arminru
Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:miscellaneous For issues that don't match any other spec label

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Oct 15, 2020 •
edited by arminru
Loading

YAML model for attributes seems to only have number type. But we have int or double as possible attribute types.

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/common/common.md#attributes
https://github.com/open-telemetry/opentelemetry-specification/blob/master/semantic_conventions/syntax.md

Once the YAML syntax and MD generator are updated (open-telemetry/build-tools#13), we need to update our YAML files here accordingly.
@anuraaga anuraaga added the spec:miscellaneous For issues that don't match any other spec label label Oct 15, 2020
@thisthat

This comment has been minimized.

Sign in to view
@arminru arminru mentioned this issue Oct 15, 2020
Closed
@arminru arminru changed the title YAML model should differentiate int and double type Update YAML files for semantic conventions once supported by markdown generator Oct 15, 2020
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Oct 15, 2020
@carlosalberto carlosalberto added the release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs label Oct 16, 2020
@andrewhsu andrewhsu added the priority:p3 Lowest priority level label Oct 16, 2020
@arminru
Copy link
Member

arminru commented Mar 9, 2021

@anuraaga There is a PR adding this functionality to the markdown generator: open-telemetry/build-tools#30

If there is no opposition on this change (distinguishing int and double), we should be able to merge it and then adapt the YAML files in the spec accordingly.
cc @open-telemetry/technical-committee @open-telemetry/specs-approvers

arminru added a commit to dynatrace-oss-contrib/opentelemetry-specification that referenced this issue Mar 16, 2021
@arminru
Update semantic conventions to distinguish between int and double
9009688 
This was recently introduced in open-telemetry/build-tools#30.
Fixes open-telemetry#1096.
@arminru arminru mentioned this issue Mar 16, 2021
Merged
@arminru arminru self-assigned this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arminru arminru

Labels
area:semantic-conventions Related to semantic conventions priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Milestone
No milestone
5 participants
@andrewhsu @anuraaga @carlosalberto @thisthat @arminru