Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear OTEL_EXPORTER_OTLP_COMPRESSION values for environment variable support #1001

Closed
wilguo opened this issue Sep 24, 2020 · 5 comments · Fixed by #1017
Closed

Unclear OTEL_EXPORTER_OTLP_COMPRESSION values for environment variable support #1001

wilguo opened this issue Sep 24, 2020 · 5 comments · Fixed by #1017
Assignees
@tigrannajaryan
Labels
priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:miscellaneous For issues that don't match any other spec label

Comments

@wilguo
Copy link

wilguo commented Sep 24, 2020

Hi everyone,

As per spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/protocol/exporter.md#opentelemetry-protocol-exporter

It says that OTEL_EXPORTER_OTLP_COMPRESSION environment variable should be supported, however I'm unclear as to what values it should take on. Could someone clarify? Thank you!
@wilguo wilguo added the spec:miscellaneous For issues that don't match any other spec label label Sep 24, 2020
@wilguo wilguo mentioned this issue Sep 24, 2020
Merged
3 tasks
@tigrannajaryan
Copy link
Member

Only "gzip" and no compression are supported today.

@wilguo
Copy link
Author

wilguo commented Sep 24, 2020

Thank you

@wilguo wilguo closed this as completed Sep 24, 2020
@aabmass
Copy link
Member

aabmass commented Sep 24, 2020

@tigrannajaryan the spec doesn't say specifically what OTEL_EXPORTER_OTLP_COMPRESSION should be for no compression. Should it be no_compression, or empty string, or un-set?

Also wondering why GRPC deflate is excluded. Is it not well supported across GRPC implementations or for compatibility with http/json?

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Sep 25, 2020 •
edited
Loading

Spec only talks about compressions for otlp/http. It is an omission that we don't define what is possible for grpc (I didn't know deflate was supported). Let's make sure we have it in the spec.

@andrewhsu andrewhsu added priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Sep 25, 2020
@andrewhsu
Copy link
Member

from the issue triage mtg today with TC, allowing changes related to this issue for GA if editorial changes only

tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Sep 25, 2020
Clarify supported compression methods for OTLP
5b16ffb 
Fixes: open-telemetry#1001 (comment)
@tigrannajaryan tigrannajaryan mentioned this issue Sep 25, 2020
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Sep 25, 2020
Clarify supported compression methods for OTLP
e40d829 
Fixes: open-telemetry#1001 (comment)
@tigrannajaryan tigrannajaryan self-assigned this Sep 25, 2020
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Sep 25, 2020
Clarify supported compression methods for OTLP
94663c7 
Fixes: open-telemetry#1001 (comment)
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Sep 29, 2020
Clarify supported compression methods for OTLP
dfdfa15 
Fixes: open-telemetry#1001 (comment)
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Sep 29, 2020
Clarify supported compression methods for OTLP
12822ee 
Fixes: open-telemetry#1001 (comment)
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Sep 29, 2020
Clarify supported compression methods for OTLP
c9801b1 
Fixes: open-telemetry#1001 (comment)
bogdandrutu pushed a commit that referenced this issue Sep 29, 2020
@tigrannajaryan
Clarify supported compression methods for OTLP (#1017)
2b10e4d 
Fixes: #1001 (comment)
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Apr 20, 2023
@tigrannajaryan
Clarify supported compression methods for OTLP (#1017)
ac8a909 
Fixes: open-telemetry/opentelemetry-specification#1001 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify supported compression methods for OTLP tigrannajaryan/opentelemetry-specification
4 participants
@andrewhsu @aabmass @tigrannajaryan @wilguo