Skip to content

Commit

Permalink
Prom compatibility: allow disabling the addition of _total suffixes o…
Browse files Browse the repository at this point in the history
…n prometheus counters (#3590)
  • Loading branch information
dashpole authored Jul 13, 2023
1 parent 8ae0f6f commit 6f84b7c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ release.

### Compatibility

- Prometheus exporters SHOULD provide configuration to disable the addition of `_total` suffixes.
([#3590](https://github.com/open-telemetry/opentelemetry-specification/pull/3590))

### SDK Configuration

### Common
Expand Down
2 changes: 1 addition & 1 deletion specification/compatibility/prometheus_and_openmetrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ An [OpenTelemetry Gauge](../metrics/data-model.md#gauge) MUST be converted to a
- The new data point's start time must match the time of the accumulated data point. If not, see [detecting alignment issues](../metrics/data-model.md#sums-detecting-alignment-issues).
- Otherwise, it MUST be dropped.

If the metric name for monotonic Sum metric points does not end in a suffix of `_total` a suffix of `_total` MUST be added, otherwise the name MUST remain unchanged.
If the metric name for monotonic Sum metric points does not end in a suffix of `_total` a suffix of `_total` MUST be added by default, otherwise the name MUST remain unchanged. Exporters SHOULD provide a configuration option to disable the addition of `_total` suffixes.
Monotonic Sum metric points with `StartTimeUnixNano` should export the `{name}_created` metric as well.

### Histograms
Expand Down

0 comments on commit 6f84b7c

Please sign in to comment.