-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup pin-project dep #830
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
hopefully fixed compilation error |
* remove pin-project from crates which weren't actually using it * switch to pin-project-lite to improve compilation time and impose fewer deps at consumers (ecosystem migrated to -lite awhile ago tokio-rs/tokio#1778)
Codecov Report
@@ Coverage Diff @@
## main #830 +/- ##
=======================================
+ Coverage 68.7% 69.8% +1.0%
=======================================
Files 115 111 -4
Lines 9346 9195 -151
=======================================
- Hits 6427 6420 -7
+ Misses 2919 2775 -144
Continue to review full report at Codecov.
|
fixed the clippy error -- seems unrelated, prob just new rust version. |
Is it currently set to "require approval for all outside collaborators" or "require approval for first time contributors"? If it is the former, than, yes, this is an explicit setting for security reasons. If it is the latter, than this is most likely just a stupid GitHub default which they added in an ad-hoc manner when folks started abusing github actions to mine crypto. |
Yeah I think you are right. We are not given full access of the repo so I cannot check the actual setting. But from what I have seen it's the case. open-telemetry/community#1023 also mentioned it. I will open a issue to ask TC change it for us. |
Looks good, just the lint remaining |
The nightly version seems to be broken now We can probably merge this as it is |
fewer deps at consumers (ecosystem migrated to -lite awhile ago
Migrate from pin-project to pin-project-lite tokio-rs/tokio#1778)