Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint issues in 1.52.0 #543

Merged
merged 4 commits into from
May 9, 2021
Merged

fix: lint issues in 1.52.0 #543

merged 4 commits into from
May 9, 2021

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented May 8, 2021

  • Also bumped the MSRV according to the README

djc
djc approved these changes May 8, 2021
View reviewed changes
opentelemetry-otlp/tests/grpc_build.rs Outdated
);
}

for entry in dict.into_iter().flatten() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rewrite this to collect() while you're at it? Potentially more efficient to allocate the correct size immediately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. But I thought the compiler could allocate the correct size with for loop also?

@codecov
Copy link

codecov bot commented May 8, 2021 •
edited
Loading

Codecov Report

Merging #543 (2bcabf3) into main (92a0d85) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #543   +/-   ##
=====================================
  Coverage   52.2%   52.2%           
=====================================
  Files         96      96           
  Lines       8506    8506           
=====================================
  Hits        4447    4447           
  Misses      4059    4059
Impacted Files Coverage Δ
opentelemetry-datadog/src/lib.rs 92.4% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a0d85...2bcabf3. Read the comment docs.

@TommyCpp TommyCpp force-pushed the tommycpp/rust_1_52 branch from 94422be to 7228628 Compare May 8, 2021 20:15
@TommyCpp TommyCpp marked this pull request as ready for review May 8, 2021 20:42
@TommyCpp TommyCpp requested a review from a team May 8, 2021 20:42
djc
djc reviewed May 8, 2021
View reviewed changes
opentelemetry-otlp/tests/grpc_build.rs
let _ = dict
.into_iter()
.flatten()
.map(|entry| {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant you could collect into map directly by yielding (entry.path(), std::fs::read_to_string()) items.

@TommyCpp TommyCpp force-pushed the tommycpp/rust_1_52 branch from 7228628 to 2bcabf3 Compare May 8, 2021 21:47
@jtescher jtescher merged commit f74705c into open-telemetry:main May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TommyCpp @djc @jtescher