Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cow<'static, str> for api::Value #332

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

djc
Copy link
Contributor

@djc djc commented Nov 2, 2020

No description provided.

@djc djc requested a review from a team November 2, 2020 20:57
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #332 into master will decrease coverage by 0.03%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   53.42%   53.38%   -0.04%     
==========================================
  Files          71       71              
  Lines        5818     5816       -2     
==========================================
- Hits         3108     3105       -3     
- Misses       2710     2711       +1     
Impacted Files Coverage Δ
opentelemetry/src/api/baggage.rs 80.00% <ø> (ø)
opentelemetry/src/exporter/metrics/stdout.rs 0.00% <ø> (ø)
opentelemetry/src/api/core.rs 59.57% <87.50%> (+1.33%) ⬆️
opentelemetry/src/sdk/env.rs 75.00% <91.66%> (-4.07%) ⬇️
opentelemetry/src/sdk/propagation/baggage.rs 96.42% <100.00%> (ø)
opentelemetry/src/sdk/resource.rs 77.57% <100.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866ae41...c60b46a. Read the comment docs.

@jtescher jtescher merged commit 734524b into open-telemetry:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants