Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify metric::data imports #2536

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

cijothomas
Copy link
Member

In future, I expect to change the module path for metrics::data. This PR is a step1, to keep overall PRs smaller.

@cijothomas cijothomas requested a review from a team as a code owner January 23, 2025 00:51
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 71.76471% with 24 lines in your changes missing coverage. Please review.

Project coverage is 77.7%. Comparing base (57d1297) to head (76380cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-stdout/src/metrics/exporter.rs 0.0% 17 Missing ⚠️
...-sdk/src/metrics/internal/exponential_histogram.rs 70.0% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/mod.rs 95.6% 2 Missing ⚠️
opentelemetry-otlp/src/exporter/http/mod.rs 0.0% 1 Missing ⚠️
opentelemetry-proto/src/transform/metrics.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2536     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.1%     
=======================================
  Files        123     123             
  Lines      23057   23050      -7     
=======================================
- Hits       17938   17931      -7     
  Misses      5119    5119             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla merged commit 3042aa0 into open-telemetry:main Jan 23, 2025
20 of 21 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-ns-fix branch January 23, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants