-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchSpanProcessor optimizations - Separate control signal queue, and wake up background thread only when required. #2526
BatchSpanProcessor optimizations - Separate control signal queue, and wake up background thread only when required. #2526
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
======================================
Coverage 77.9% 77.9%
======================================
Files 123 123
Lines 22944 23056 +112
======================================
+ Hits 17880 17980 +100
- Misses 5064 5076 +12 ☔ View full report in Codecov by Sentry. |
&config, | ||
); | ||
// Reset the export span message sent flag now it has has been processed. | ||
export_span_message_sent.store(false, Ordering::Relaxed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reset need to happen before the exporting. Just like logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, need to make this fix: https://github.com/open-telemetry/opentelemetry-rust/pull/2526/files#r1924235350 before merge
Fixes: Towards #2493
Changes
Similar to the BatchLogProcessor in #2494 :
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes