Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BatchLogProcessor #2510

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jan 14, 2025

Addresses #2494 (comment)

Changes

  • For every export trigger, find the export target: the number of logs in the channel at the time the trigger is invoked
  • Export logs until the export target is met

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (888d5a3) to head (c426db4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 81.8% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2510   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22943   22949    +6     
=====================================
+ Hits       17875   17880    +5     
- Misses      5068    5069    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla marked this pull request as ready for review January 14, 2025 19:29
@utpilla utpilla requested a review from a team as a code owner January 14, 2025 19:29
@cijothomas cijothomas merged commit 5aa9120 into open-telemetry:main Jan 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants