Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics benchmarks #2502

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jan 8, 2025

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner January 8, 2025 21:22
&[
KeyValue::new(
"attribute1",
attribute_values[index_first_attribute].as_str().to_owned(),
Copy link
Contributor Author

@utpilla utpilla Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #2089, we would be able to simply pass a string slice and avoid the string allocation:

Suggested change
attribute_values[index_first_attribute].as_str().to_owned(),
attribute_values[index_first_attribute].as_str(),

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (a1dda22) to head (5f0e3d4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2502   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22888   22888           
=====================================
  Hits       17839   17839           
  Misses      5049    5049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@utpilla utpilla merged commit 6cc327d into open-telemetry:main Jan 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants