Move propagators and ID generators #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but let's wait for the discussion in open-telemetry/opentelemetry-specification#1047 to settle before we go either way |
|
O whoops. Didn't realize it was still an open discussion... |
6 tasks
|
@awiede actually it does seem likely that b3 for example should be moved. Think we should just merge this and potentially move some of them back if that is the decision? |
|
That works. If we do have to move them back I'd like to nest them under a trace mod and export like in #255. |
jtescher
approved these changes
Oct 6, 2020
|
@awiede looks good, just have to update the imports 😬 |
awiede
force-pushed
the
move-propagator
branch
from
017b616
to
56068cc
Compare
added 3 commits
October 6, 2020 19:16
Move default W3 propagator implementation to SDK. Create a propagator and id_generator sub mod.
Move AWS X-Ray ID Generator from contrib to the SDK.
Move third party propagators from contrib to SDK.
awiede
force-pushed
the
move-propagator
branch
from
56068cc
to
0eae9da
Compare
Fix rebase.
awiede
force-pushed
the
move-propagator
branch
from
0eae9da
to
6670d6b
Compare
|
Yikes! That was a nasty rebase. I think I got it all fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #235
trace_context_propagatorimplementation tosdkcontribtosdkid_generatorfromcontrbitosdk