Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure extractors are case insensitive #193

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Ensure extractors are case insensitive #193

merged 2 commits into from
Aug 24, 2020

Conversation

jtescher
Copy link
Member

No description provided.

@jtescher jtescher requested a review from a team August 23, 2020 18:30
@jtescher jtescher mentioned this pull request Aug 23, 2020
Merged
TommyCpp
TommyCpp approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could mention that extractors are not case sensitive somewhere in comments but otherwise LGTM. Thanks!

@jtescher
Copy link
Member Author

Yeah I think we can update the docs to be more in sync with the latest spec in a future PR as GA for tracing is close 👍

@jtescher jtescher merged commit 92e4ff3 into master Aug 24, 2020
@jtescher jtescher deleted the case-insensitive-extractors branch August 24, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtescher @TommyCpp