-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Logs and Spans by Resource and Instrumentation Scope in OTLP Exporter #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
changed the title
Group Logs by Resource and Instrumentation Scope in OTLP Exporter before export
Group logs and spans by Resource and Instrumentation Scope in OTLP Exporter before export
Jun 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
=======================================
+ Coverage 74.6% 75.0% +0.3%
=======================================
Files 122 122
Lines 20001 20279 +278
=======================================
+ Hits 14933 15212 +279
+ Misses 5068 5067 -1 ☔ View full report in Codecov by Sentry. |
lalitb
changed the title
Group logs and spans by Resource and Instrumentation Scope in OTLP Exporter before export
Group Logs and Spans by Resource and Instrumentation Scope in OTLP Exporter
Jun 11, 2024
Looks good. Thanks for covering both logs and traces! |
cijothomas
reviewed
Jun 19, 2024
cijothomas
reviewed
Jun 19, 2024
cijothomas
reviewed
Jun 19, 2024
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
cijothomas
reviewed
Jun 20, 2024
cijothomas
reviewed
Jun 20, 2024
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
cijothomas
approved these changes
Jun 26, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactor the log and span batching mechanism in the OTLP exporters to combine logs with the same resource and instrumentation scope before export.
Input:
(res1, lib1, log1), (res1, lib1, log2), (res1, lib2, log3), (res1, lib1, log4)
Output:
(res1, (lib1, (log1, log2, log4)), (lib2, (log3)))
The main changes include:
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes