-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metric SDK] - Avoid exposing AttributeSet to exporters - Part2 #1794
[Metric SDK] - Avoid exposing AttributeSet to exporters - Part2 #1794
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1794 +/- ##
=====================================
Coverage 73.5% 73.5%
=====================================
Files 125 124 -1
Lines 19490 19482 -8
=====================================
- Hits 14340 14338 -2
+ Misses 5150 5144 -6 ☔ View full report in Codecov by Sentry. |
That is a good point. Keeping it enabled means all PRs will be red until new release. But I believe the CI check show exactly what are the breaking changes (not for a given PR, but cumulative...)... |
Can we make the check opt-in like integration test? And we can manually run it if we feel it's needed? Can make it mandatory for all crates once one of them reaches 1.0 |
Continuing #1792
This applies changes to ExponentialHistograms
With this change
AttributeSet
is only required within the SDK only. (It is still marked public, expecting to clear that along with the benchmarks that use it next)With this, I think I can continue with #1780 (comment)