Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric SDK] - Avoid exposing AttributeSet to exporters - Part2 #1794

Merged
merged 6 commits into from
May 21, 2024

Conversation

cijothomas
Copy link
Member

Continuing #1792
This applies changes to ExponentialHistograms
With this change AttributeSet is only required within the SDK only. (It is still marked public, expecting to clear that along with the benchmarks that use it next)

With this, I think I can continue with #1780 (comment)

@cijothomas cijothomas requested a review from a team May 21, 2024 01:39
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 89.16667% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 73.5%. Comparing base (5937065) to head (61cfda7).

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 88.5% 12 Missing ⚠️
opentelemetry-stdout/src/metrics/transform.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1794   +/-   ##
=====================================
  Coverage   73.5%   73.5%           
=====================================
  Files        125     124    -1     
  Lines      19490   19482    -8     
=====================================
- Hits       14340   14338    -2     
+ Misses      5150    5144    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

image
Semver check works nicely!

@cijothomas cijothomas merged commit d08a861 into open-telemetry:main May 21, 2024
21 of 22 checks passed
@cijothomas cijothomas deleted the cijothomas/attributeset-2 branch May 21, 2024 23:10
@TommyCpp
Copy link
Contributor

image Semver check works nicely!

Are we expecting with this change the semcheck will fail until a new version release? If so probably we can disable it until the next release?

@cijothomas
Copy link
Member Author

image Semver check works nicely!

Are we expecting with this change the semcheck will fail until a new version release? If so probably we can disable it until the next release?

That is a good point. Keeping it enabled means all PRs will be red until new release. But I believe the CI check show exactly what are the breaking changes (not for a given PR, but cumulative...)...
Let me think more about it.

@TommyCpp
Copy link
Contributor

image Semver check works nicely!

Are we expecting with this change the semcheck will fail until a new version release? If so probably we can disable it until the next release?

That is a good point. Keeping it enabled means all PRs will be red until new release. But I believe the CI check show exactly what are the breaking changes (not for a given PR, but cumulative...)...

Let me think more about it.

Can we make the check opt-in like integration test? And we can manually run it if we feel it's needed? Can make it mandatory for all crates once one of them reaches 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants