Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTLP proto version to 1.1.0 #1482

Merged
merged 8 commits into from
Jan 25, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 18, 2024

Changes

The significant change in otel-proto v1.1.0 is - Add flags field to Span and Span/Link for W3C-specified Trace Context flags . #503

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team January 18, 2024 22:20
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (16fd1ab) 63.2% compared to head (6c5320e) 63.7%.
Report is 2 commits behind head on main.

Files Patch % Lines
opentelemetry-proto/src/transform/trace.rs 25.0% 3 Missing ⚠️
opentelemetry-stdout/src/trace/transform.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1482     +/-   ##
=======================================
+ Coverage   63.2%   63.7%   +0.5%     
=======================================
  Files        147     142      -5     
  Lines      19664   19499    -165     
=======================================
+ Hits       12428   12432      +4     
+ Misses      7236    7067    -169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we update opentelemetry-stdout to add the new fields as well? Also a changeset

@lalitb
Copy link
Member Author

lalitb commented Jan 25, 2024

Looks good, can we update opentelemetry-stdout to add the new fields as well? Also a changeset

Thanks, both are done.

@cijothomas cijothomas changed the title Update OTLP spec version to 1.1.0 Update OTLP proto version to 1.1.0 Jan 25, 2024
@cijothomas cijothomas merged commit 27b19b6 into open-telemetry:main Jan 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants