Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to tonic 0.9 #1016

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 2, 2023

See hyperium/tonic#1337

I just updated the versions and ran cargo test, committing the changed generated code as requested.

@SimenB SimenB requested a review from a team April 2, 2023 07:22
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.2 ⚠️

Comparison is base (3597479) 57.2% compared to head (cb75f3f) 57.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1016     +/-   ##
=======================================
- Coverage   57.2%   57.0%   -0.2%     
=======================================
  Files        143     143             
  Lines      17464   17522     +58     
=======================================
  Hits        9999    9999             
- Misses      7465    7523     +58     
Impacted Files Coverage Δ
...ry-stackdriver/src/proto/devtools/cloudtrace/v2.rs 2.5% <0.0%> (-0.4%) ⬇️
opentelemetry-stackdriver/src/proto/logging/v2.rs 0.0% <0.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djc
Copy link
Contributor

djc commented Apr 3, 2023

LGTM, thanks! I wonder if we can release this as an API-compatible release in some of the crates at least, since we just did a release...

@TommyCpp TommyCpp merged commit 482d951 into open-telemetry:main Apr 18, 2023
@SimenB SimenB deleted the upgrade-tonic branch April 18, 2023 06:03
@SimenB
Copy link
Contributor Author

SimenB commented May 24, 2023

@djc will this be released anytime soon? 🙂

@djc
Copy link
Contributor

djc commented May 24, 2023

Not sure if there are plans for a next release. @TommyCpp @jtescher thoughts?

@purkhusid
Copy link

Would love to see this released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants