-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New metrics SDK #1000
Merged
Merged
New metrics SDK #1000
Commits on Mar 19, 2023
-
This patch updates the metrics SDK to the latest spec. The following breaking changes are introduced. Metrics API changes: * Move `AttributeSet` to SDK as it's not mentioned in the spec or used in the api * Consolidate `AsyncCounter`, `AsyncUpDownCounter`, and `AsyncGauge` into `AsyncInstrument` trait and add downcasting for observer callbacks. * Add `AsyncInstrumentBuilder` to allow per-instrument callback configuration. * Allow metric `name` and `description` fields to be `Cow<'static, str>` * Warn on metric misconfiguration when using instrument builder `init` rather than returning error * Update `Meter::register_callback` to take a list of async instruments and validate they are registered in the callback through the associated `Observer` * Allow registered callbacks to be unregistered. Metrics SDK changes: * Introduce `Scope` as type alias for `InstrumentationLibrary` * Update `Aggregation` to match aggregation spec * Refactor `BasicController` to spec compliant `ManualReader` * Refactor `PushController` to spec compliant `PeriodicReader` * Update metric data fields to match spec, including exemplars. * Split `MetricsExporter` into `Reader`s and `PushMetricExporter`s * Add `View` implementation * Remove `AtomicNumber`s * Refactor `Processor`s into `Pipeline` Metrics exporter changes: * Update otlp exporter to match new metrics data * Update otlp exporter configuration to allow aggregation and temporality selectors to be optional. * Update prometheus exporter to match new metrics data Example changes: * Update otlp metrics and prometheus examples. * Remove basic example as we should be focusing on the OTLP variants
Configuration menu - View commit details
-
Copy full SHA for e242ae0 - Browse repository at this point
Copy the full SHA e242ae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5874ac9 - Browse repository at this point
Copy the full SHA 5874ac9View commit details -
Configuration menu - View commit details
-
Copy full SHA for be4b49f - Browse repository at this point
Copy the full SHA be4b49fView commit details
Commits on Mar 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e6a5afb - Browse repository at this point
Copy the full SHA e6a5afbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d80bce - Browse repository at this point
Copy the full SHA 8d80bceView commit details
Commits on Mar 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 16f9907 - Browse repository at this point
Copy the full SHA 16f9907View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e5eeb2 - Browse repository at this point
Copy the full SHA 4e5eeb2View commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6ca2749 - Browse repository at this point
Copy the full SHA 6ca2749View commit details
Commits on Mar 26, 2023
-
Merge branch 'main' into new-metrics
# Conflicts: # opentelemetry-dynatrace/Cargo.toml # opentelemetry-otlp/Cargo.toml # opentelemetry-prometheus/Cargo.toml
Configuration menu - View commit details
-
Copy full SHA for 2ffa68a - Browse repository at this point
Copy the full SHA 2ffa68aView commit details
Commits on Mar 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6d722b8 - Browse repository at this point
Copy the full SHA 6d722b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ab6437 - Browse repository at this point
Copy the full SHA 7ab6437View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5718ba - Browse repository at this point
Copy the full SHA c5718baView commit details -
Configuration menu - View commit details
-
Copy full SHA for e91b7cf - Browse repository at this point
Copy the full SHA e91b7cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c57d90b - Browse repository at this point
Copy the full SHA c57d90bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0599689 - Browse repository at this point
Copy the full SHA 0599689View commit details -
Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for 98d0c02 - Browse repository at this point
Copy the full SHA 98d0c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f280a6 - Browse repository at this point
Copy the full SHA 3f280a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccefdb6 - Browse repository at this point
Copy the full SHA ccefdb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ea2e6d - Browse repository at this point
Copy the full SHA 0ea2e6dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.