feat: clean up trace SDK APIs and remove integration tests for jaeger

opentelemetry-appender-tracing/src/layer.rs

@@ -213,7 +213,8 @@ mod tests {
     use opentelemetry::{logs::AnyValue, Key};
     use opentelemetry_sdk::logs::LoggerProvider;
     use opentelemetry_sdk::testing::logs::InMemoryLogsExporter;
-    use opentelemetry_sdk::trace::{config, Sampler, TracerProvider};
+    use opentelemetry_sdk::trace;
+    use opentelemetry_sdk::trace::{Sampler, TracerProvider};
     use tracing::error;
     use tracing_subscriber::layer::SubscriberExt;
 
@@ -301,7 +302,7 @@ mod tests {
 
         // setup tracing as well.
         let tracer_provider = TracerProvider::builder()
-            .with_config(config().with_sampler(Sampler::AlwaysOn))
+            .with_config(trace::Config::default().with_sampler(Sampler::AlwaysOn))
             .build();
         let tracer = tracer_provider.tracer("test-tracer");
 
@@ -465,7 +466,7 @@ mod tests {
 
         // setup tracing as well.
         let tracer_provider = TracerProvider::builder()
-            .with_config(config().with_sampler(Sampler::AlwaysOn))
+            .with_config(trace::Config::default().with_sampler(Sampler::AlwaysOn))
             .build();
         let tracer = tracer_provider.tracer("test-tracer");
 

opentelemetry-jaeger/Cargo.toml

@@ -85,7 +85,6 @@ full = [
     "rt-tokio",
     "rt-tokio-current-thread",
     "rt-async-std",
-    "integration_test",
 ]
 default = []
 collector_client = ["http", "opentelemetry-http"]
@@ -107,4 +106,3 @@ wasm_collector_client = [
 rt-tokio = ["tokio", "opentelemetry_sdk/rt-tokio"]
 rt-tokio-current-thread = ["tokio", "opentelemetry_sdk/rt-tokio-current-thread"]
 rt-async-std = ["async-std", "opentelemetry_sdk/rt-async-std"]
-integration_test = ["tonic", "prost", "prost-types", "rt-tokio", "collector_client", "hyper_collector_client", "hyper_tls_collector_client", "reqwest_collector_client", "isahc_collector_client"]

opentelemetry-sdk/CHANGELOG.md

@@ -28,6 +28,10 @@
   - After `shutdown`, `LogProcessor` will not process any new logs
 - Moving LogRecord implementation to the SDK. [1702](https://github.com/open-telemetry/opentelemetry-rust/pull/1702).
     - Relocated `LogRecord` struct to SDK, as an implementation for the trait in the API.
+- Clean up public methods in SDK.
+    - [`TracerProvider::span_processors`] and [`TracerProvider::config`] was removed as it's not part of the spec.
+    - Added `non_exhaustive` annotation to [`trace::Config`]. Marked [`config`] as deprecated since it's only a wrapper for `Config::default`
+    - Removed [`Tracer::tracer_provder`] and [`Tracer::instrument_libraries`] as it's not part of the spec.
 
 ## v0.22.1
 

opentelemetry-sdk/benches/context.rs

@@ -10,7 +10,8 @@ use opentelemetry::{
 };
 use opentelemetry_sdk::{
     export::trace::{ExportResult, SpanData, SpanExporter},
-    trace::{config, Sampler, TracerProvider},
+    trace,
+    trace::{Sampler, TracerProvider},
 };
 #[cfg(not(target_os = "windows"))]
 use pprof::criterion::{Output, PProfProfiler};
@@ -126,7 +127,9 @@ impl Display for Environment {
 
 fn parent_sampled_tracer(inner_sampler: Sampler) -> (TracerProvider, BoxedTracer) {
     let provider = TracerProvider::builder()
-        .with_config(config().with_sampler(Sampler::ParentBased(Box::new(inner_sampler))))
+        .with_config(
+            trace::Config::default().with_sampler(Sampler::ParentBased(Box::new(inner_sampler))),
+        )
         .with_simple_exporter(NoopExporter)
         .build();
     let tracer = provider.tracer(module_path!());

opentelemetry-sdk/benches/log.rs

@@ -12,7 +12,8 @@ use opentelemetry::trace::TracerProvider as _;
 use opentelemetry::Key;
 use opentelemetry_sdk::export::logs::{LogData, LogExporter};
 use opentelemetry_sdk::logs::{Logger, LoggerProvider};
-use opentelemetry_sdk::trace::{config, Sampler, TracerProvider};
+use opentelemetry_sdk::trace;
+use opentelemetry_sdk::trace::{Sampler, TracerProvider};
 
 #[derive(Debug)]
 struct VoidExporter;
@@ -46,7 +47,7 @@ fn log_benchmark_group<F: Fn(&Logger)>(c: &mut Criterion, name: &str, f: F) {
 
         // setup tracing as well.
         let tracer_provider = TracerProvider::builder()
-            .with_config(config().with_sampler(Sampler::AlwaysOn))
+            .with_config(trace::Config::default().with_sampler(Sampler::AlwaysOn))
             .build();
         let tracer = tracer_provider.tracer("bench-tracer");
 

opentelemetry-sdk/benches/span_builder.rs

@@ -54,7 +54,7 @@ fn span_builder_benchmark_group(c: &mut Criterion) {
 
 fn not_sampled_provider() -> (sdktrace::TracerProvider, sdktrace::Tracer) {
     let provider = sdktrace::TracerProvider::builder()
-        .with_config(sdktrace::config().with_sampler(sdktrace::Sampler::AlwaysOff))
+        .with_config(sdktrace::Config::default().with_sampler(sdktrace::Sampler::AlwaysOff))
         .with_simple_exporter(NoopExporter)
         .build();
     let tracer = provider.tracer("not-sampled");

opentelemetry-sdk/benches/trace.rs

@@ -70,7 +70,7 @@ fn trace_benchmark_group<F: Fn(&sdktrace::Tracer)>(c: &mut Criterion, name: &str
 
     group.bench_function("always-sample", |b| {
         let provider = sdktrace::TracerProvider::builder()
-            .with_config(sdktrace::config().with_sampler(sdktrace::Sampler::AlwaysOn))
+            .with_config(sdktrace::Config::default().with_sampler(sdktrace::Sampler::AlwaysOn))
             .with_simple_exporter(VoidExporter)
             .build();
         let always_sample = provider.tracer("always-sample");
@@ -80,7 +80,7 @@ fn trace_benchmark_group<F: Fn(&sdktrace::Tracer)>(c: &mut Criterion, name: &str
 
     group.bench_function("never-sample", |b| {
         let provider = sdktrace::TracerProvider::builder()
-            .with_config(sdktrace::config().with_sampler(sdktrace::Sampler::AlwaysOff))
+            .with_config(sdktrace::Config::default().with_sampler(sdktrace::Sampler::AlwaysOff))
             .with_simple_exporter(VoidExporter)
             .build();
         let never_sample = provider.tracer("never-sample");