-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add host.id resource detector #57
Conversation
The slackdriver build is unrelated to this PR changes - @djc if you know what could be causing this:
|
I think that's because yup-oauth2 made a semver-compatibility mistake... I notified the maintainer. |
@alvarocabanas Can you fix the CI failures, and we are good to merge. Thank you! |
Ooops.. Sorry! CI failure is not your code ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
+ Coverage 52.0% 52.3% +0.2%
=======================================
Files 37 38 +1
Lines 4938 4967 +29
=======================================
+ Hits 2569 2598 +29
Misses 2369 2369 ☔ View full report in Codecov by Sentry. |
@alvarocabanas one final lint issue and we are good! |
Fixed in last commit. |
looks like one more. I think the precommit.sh can help catch it locally. |
Sure, thanks, now it seems all are fixed. |
Changes
Add the Host Resource detector retrieving the "host.id" as defined in: https://opentelemetry.io/docs/specs/semconv/resource/host/
Defined in #56
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changesCo-authored-by: rogercoll rogercoll@users.noreply.github.com