Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackdriver - use upstream otel-rust dependencies from last common commit #24

Conversation

ivan-brko
Copy link
Contributor

@ivan-brko ivan-brko commented Jan 16, 2024

Fixes

Fixes compile issues for opentelemetry-stackdriver.
Using the upstream commit just before opentelemetry-stackdriver was removed from the core repo to contrib (6175c3f1edf8510d947a6543c68512408ae15836).

image

@djc sorry for the constant spamming, hope I got it right this time, the crate is building without any issues. opentelemetry-semantic-conventions was set to a crate version, but it also had to be set to the commit.

Changes

Temporarily depend on specific commit in the upstream repository, until new versions of those crates are released. This allows the library to be built and new features developed in the meantime.
This was proposed in #8.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ivan-brko ivan-brko requested a review from a team January 16, 2024 16:19
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3e0d18) 40.4% compared to head (d7d38dc) 40.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #24   +/-   ##
=====================================
  Coverage   40.4%   40.4%           
=====================================
  Files         12      12           
  Lines       1277    1279    +2     
=====================================
+ Hits         516     517    +1     
- Misses       761     762    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdost hdost merged commit 3827119 into open-telemetry:main Jan 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants