Emit metric points as unique ETW events #111
Conversation
…itted for each data point within metrics
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
+ Coverage 52.3% 58.3% +6.0%
=======================================
Files 38 39 +1
Lines 4967 5806 +839
=======================================
+ Hits 2598 3390 +792
- Misses 2369 2416 +47 ☔ View full report in Codecov by Sentry. |
….com:mattbodd/opentelemetry-rust-contrib into dev/mboddewy/emit_etw_metrics_point_by_point
| ))); | ||
| } | ||
|
|
||
| for resource_metric in resource_metrics { |
There was a problem hiding this comment.
the approach used in this PR is extremely inefficient, as it clones the entire metrics and recreates them into a format that the opentelemetry-proto is able to serialize. This is okay for alpha, and will help resolve the size limit issue, but this must be done in a efficient way before stabilizing the component. (that might require support from upstream sdk)
There was a problem hiding this comment.
Agreed. I'm working on a more performant solution but am proposing this PR as an immediate fix for #104
There was a problem hiding this comment.
This is okay for an immediate fix.
Part of #104
Changes
opentelemetry_sdk::metrics::data::ResourceMetricsfor eachopentelemetry_sdk::metrics::data::Metricdata point and emits these as ETW eventsMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes