Replace format!() by heapless fmt for i64, f64 and bool

opentelemetry-datadog/Cargo.toml

@@ -37,6 +37,8 @@ thiserror = "1.0"
 itertools = "0.11"
 http = "0.2"
 futures-core = "0.3"
+ryu = "1"
+itoa = "1"
 
 [dev-dependencies]
 async-trait = "0.1"

opentelemetry-datadog/src/exporter/intern.rs

@@ -1,6 +1,7 @@
 use indexmap::set::IndexSet;
 use opentelemetry::Value;
-use std::{borrow::Cow, hash::Hash};
+use rmp::encode::{RmpWrite, ValueWriteError};
+use std::hash::Hash;
 
 #[derive(PartialEq)]
 pub(crate) enum InternValue<'a> {
@@ -16,8 +17,7 @@ impl<'a> Hash for InternValue<'a> {
                 Value::Bool(x) => x.hash(state),
                 Value::I64(x) => x.hash(state),
                 Value::String(x) => x.hash(state),
-
-                Value::F64(x) => std::ptr::hash(std::ptr::addr_of!(x), state),
+                Value::F64(x) => x.to_bits().hash(state),
                 Value::Array(x) => std::ptr::hash(std::ptr::addr_of!(x), state),
             },
         }
@@ -27,10 +27,21 @@ impl<'a> Hash for InternValue<'a> {
 impl<'a> Eq for InternValue<'a> {}
 
 impl<'a> InternValue<'a> {
-    pub(crate) fn as_str(&self) -> Cow<'a, str> {
+    pub(crate) fn write_as_str<W: RmpWrite>(
+        &self,
+        payload: &mut W,
+    ) -> Result<(), ValueWriteError<W::Error>> {
         match self {
-            InternValue::RegularString(x) => Cow::Borrowed(x),
-            InternValue::OpenTelemetryValue(x) => x.as_str(),
+            InternValue::RegularString(x) => rmp::encode::write_str(payload, x),
+            InternValue::OpenTelemetryValue(v) => match v {
+                Value::Bool(x) => {
+                    rmp::encode::write_str(payload, if *x { "true" } else { "false" })
+                }
+                Value::I64(x) => rmp::encode::write_str(payload, itoa::Buffer::new().format(*x)),
+                Value::F64(x) => rmp::encode::write_str(payload, ryu::Buffer::new().format(*x)),
+                Value::String(x) => rmp::encode::write_str(payload, x.as_ref()),
+                x => rmp::encode::write_str(payload, x.as_str().as_ref()),
+            },
         }
     }
 }

opentelemetry-datadog/src/exporter/model/v05.rs

@@ -94,7 +94,7 @@ where
 
     rmp::encode::write_array_len(&mut payload, interner.len())?;
     for data in interner.iter() {
-        rmp::encode::write_str(&mut payload, data.as_str().as_ref())?;
+        data.write_as_str(&mut payload)?;
     }
 
     payload.append(&mut encoded_traces);
@@ -171,12 +171,12 @@ where
             rmp::encode::write_array_len(&mut encoded, SPAN_NUM_ELEMENTS)?;
             rmp::encode::write_u32(
                 &mut encoded,
-                interner.intern(get_service_name(&span, model_config)),
+                interner.intern(get_service_name(span, model_config)),
             )?;
-            rmp::encode::write_u32(&mut encoded, interner.intern(get_name(&span, model_config)))?;
+            rmp::encode::write_u32(&mut encoded, interner.intern(get_name(span, model_config)))?;
             rmp::encode::write_u32(
                 &mut encoded,
-                interner.intern(get_resource(&span, model_config)),
+                interner.intern(get_resource(span, model_config)),
             )?;
             rmp::encode::write_u64(
                 &mut encoded,
@@ -208,7 +208,7 @@ where
             )?;
             for (key, value) in span.resource.iter() {
                 rmp::encode::write_u32(&mut encoded, interner.intern(key.as_str()))?;
-                rmp::encode::write_u32(&mut encoded, interner.intern_value(&value))?;
+                rmp::encode::write_u32(&mut encoded, interner.intern_value(value))?;
             }
 
             write_unified_tags(&mut encoded, interner, unified_tags)?;