Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle otlp exporter race condition gzip errors with retry #983

Merged

Conversation

ericmustin
Copy link
Contributor

Summary

We'd like to be able enable gzip compression by default with the otlp exporter, however internally we've noticed somewhat arbitrary Zlib::DataError exceptions as described in this comment #934 (comment). So, given this is likely a race condition that only occurs under specific and hard to reproduce scenarios, the least we can do is attempt to retry a few times. If we notice the errors become more consistent we can try to address in an alternate way. For now let's just handle the exception, emit a metric upon retry, and implement the usual backoff approach.

Copy link
Contributor

@robertlaurin robertlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@robertlaurin robertlaurin merged commit ef72aad into open-telemetry:main Oct 19, 2021
@robertlaurin robertlaurin deleted the update_otlp_exporter_gzip branch October 19, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants