fix: handle otlp exporter race condition gzip errors with retry #983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We'd like to be able enable gzip compression by default with the otlp exporter, however internally we've noticed somewhat arbitrary
Zlib::DataError
exceptions as described in this comment #934 (comment). So, given this is likely a race condition that only occurs under specific and hard to reproduce scenarios, the least we can do is attempt to retry a few times. If we notice the errors become more consistent we can try to address in an alternate way. For now let's just handle the exception, emit a metric upon retry, and implement the usual backoff approach.