Rename excon component attribute from http to excon #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rack middleware uses the same component value. So excon and rack requests are currently impossible to differenciate
dmathieu
requested review from
bai,
dazuma,
elskwid,
fbogsany,
luvtechno and
mwear
as code owners
fbogsany
approved these changes
May 15, 2020
|
Technically, we are supposed to remove the component attribute from this (and all other) instrumentation. See: open-telemetry/opentelemetry-specification#447. We should replace this with the InstrumentationLibrary (see: open-telemetry/oteps#84) and make that available on SpanData for export. I will try to write some issues up about this shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rack middleware uses the same component value. So excon and rack
requests are currently impossible to differenciate.
The value
exconseems like the most explicit one to me. I'm open to any alternative though.