In types.Attributes, change Dict -> Mapping #989
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes these kinds of type errors which I'm seeing in the Google cloud exporter:
Dict
is invariant (see this mypy FAQ). UsingMapping
solves this because it is covariant.Mapping
is immutable so MyPy will complain if you try and set a value on it.Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
For GoogleCloudPlatform/opentelemetry-operations-python#64
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This is just a type annotation change. All mypy assertions are passing
Checklist:
(rest are N/A)