Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type signature of get_metrics_data() to accept "None" return type #4186

Conversation

Ali-Alnosairi
Copy link
Contributor

@Ali-Alnosairi Ali-Alnosairi commented Sep 13, 2024

Description

Fixes #4047

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Ali-Alnosairi Ali-Alnosairi requested a review from a team September 13, 2024 15:41
@Ali-Alnosairi
Copy link
Contributor Author

Ali-Alnosairi commented Sep 13, 2024

@ocelotl , @xrmx, @emdneto
would someone please review this PR!

@Ali-Alnosairi
Copy link
Contributor Author

Hey @emdneto ,
would you please review this PR!

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 17, 2024
@emdneto emdneto requested a review from a team as a code owner September 19, 2024 15:56
@lzchen lzchen merged commit f15821f into open-telemetry:main Sep 19, 2024
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type signature for get_metrics_data() says return type should never be None (but it can be)
4 participants