Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TypeError from opentelemetry.context.contextvars_context in detach #4164

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hyoinandout
Copy link
Contributor

@hyoinandout hyoinandout commented Aug 29, 2024

Description

Fixes #4163 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@lzchen
Copy link
Contributor

lzchen commented Sep 4, 2024

@hyoinandout

Also please convert to a PR when ready for review.

@hyoinandout
Copy link
Contributor Author

Hi @lzchen, sure, I would like to, just wondering why the checks for instrumentation failed... May I have to implement Context to be subscriptable in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError from opentelemetry.context.contextvars_context in detach
3 participants