fix schema_url constants in semconv #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
requested review from
a team and
lmolkova
and removed request for
a team
xrmx
approved these changes
Jul 22, 2024
opentelemetry-semantic-conventions/src/opentelemetry/semconv/schemas.py
Outdated
Show resolved
Hide resolved
opentelemetry-semantic-conventions/src/opentelemetry/semconv/schemas.py
Outdated
Show resolved
Hide resolved
|
Good catch! |
…chemas.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…chemas.py Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
lmolkova
reviewed
Jul 22, 2024
lzchen
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, we have an inaccessible constant for SCHEMA_URL; fix this. I don't know the impact of this in practice for users, but I can imagine that using the wrong schema_url, will lead to issues in a telemetry consumer which does schema translations when needed to compare the schema url's (i.e., schemaprocessor) . Also, this can affect the schema_url we are setting in instrumentation scope for instrumentation libraries that are being migrated to new semconv in contrib repo, see https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py#L396