-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: RandomIdGenerator can generate invalid Span/Trace Ids #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Jun 4, 2024
correct the PR id
emdneto
reviewed
Jun 4, 2024
zhihali
changed the title
bugfix: RandomIdGenerator can generate invalid Span/Trace Ids #3921
bugfix: RandomIdGenerator can generate invalid Span/Trace Ids
Jun 4, 2024
emdneto
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint job is failing. I suggest you setup pre-commit which can help avoid that. See CONTRIBUTING.md
emdneto
reviewed
Jun 12, 2024
emdneto
reviewed
Jun 12, 2024
lzchen
approved these changes
Jun 12, 2024
emdneto
reviewed
Jun 12, 2024
emdneto
approved these changes
Jun 12, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the RandomIdGenerator class to ensure that it generates valid span and trace IDs by avoiding specific invalid values.
Fixes #3921
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I wrote 2 new tests for this one, when it generate a invalid id(for example: 0), the generate function will run again.
Does This PR Require a Contrib Repo Change?
Checklist: